Fix/rlp receipt limits (#9667)

* Revert unnecessary change

* Remove small limits on single array receipts

* simplify DefaultLimit

* Increase default limit to 1 MB for safety

* Set MaxHashesFetch at 16K and use it in GetReceiptsMessage

* Remove test - IMO it is obsolete, we can handle large receipts, we just limit to 2MB

* whitepsace

Author: LukaszRozmej

src/Nethermind/Nethermind.Network.Stats/SyncLimits/NethermindSyncLimits.cs

@@ -5,10 +5,10 @@ namespace Nethermind.Stats.SyncLimits
 {
     public static class NethermindSyncLimits
     {
-        public const int MaxHeaderFetch = 1024; // Number of block headers to be fetched per retrieval request
-        public const int MaxBodyFetch = 512; // Number of block bodies to be fetched per retrieval request
-        public const int MaxReceiptFetch = 512; // Number of transaction receipts to allow fetching per request
+        public const int MaxHeaderFetch = 512; // Number of block headers to be fetched per retrieval request
+        public const int MaxBodyFetch = 256; // Number of block bodies to be fetched per retrieval request
+        public const int MaxReceiptFetch = 256; // Number of transaction receipts to allow fetching per request
         public const int MaxCodeFetch = 1024; // Number of contract codes to allow fetching per request
-        public const int MaxHashesFetch = 10000; // Number of hashes to allow fetching per request
+        public const int MaxHashesFetch = 16384; // Number of hashes to allow fetching per request
     }
 }

src/Nethermind/Nethermind.Network.Test/P2P/Subprotocols/Eth/V63/Eth63ProtocolHandlerTests.cs

@@ -129,17 +129,6 @@ public async Task Limit_receipt_request()
         private ArrayPoolList<T> RepeatPooled<T>(T txReceipts, int count) =>
             Enumerable.Repeat(txReceipts, count).ToPooledList(count).AddTo(_disposables);
 
-        [Test]
-        public void Will_not_serve_receipts_requests_above_512()
-        {
-            using GetReceiptsMessage getReceiptsMessage = new(RepeatPooled(Keccak.Zero, NethermindSyncLimits.MaxReceiptFetch + 1));
-            Packet getReceiptsPacket =
-                new("eth", Eth63MessageCode.GetReceipts, _ctx._getReceiptMessageSerializer.Serialize(getReceiptsMessage));
-
-            Assert.Throws<RlpLimitException>(() => _ctx.ProtocolHandler.HandleMessage(getReceiptsPacket));
-            _ctx.Session.Received().InitiateDisconnect(Arg.Any<DisconnectReason>(), Arg.Any<string>());
-        }
-
         [Test]
         public void Will_not_send_messages_larger_than_2MB()
         {

src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V63/Messages/GetReceiptsMessageSerializer.cs

@@ -11,7 +11,7 @@ namespace Nethermind.Network.P2P.Subprotocols.Eth.V63.Messages
 {
     public class GetReceiptsMessageSerializer : HashesMessageSerializer<GetReceiptsMessage>
     {
-        private static readonly RlpLimit RlpLimit = RlpLimit.For<GetReceiptsMessage>(NethermindSyncLimits.MaxReceiptFetch, nameof(GetReceiptsMessage.Hashes));
+        private static readonly RlpLimit RlpLimit = RlpLimit.For<GetReceiptsMessage>(NethermindSyncLimits.MaxHashesFetch, nameof(GetReceiptsMessage.Hashes));
 
         public static GetReceiptsMessage Deserialize(byte[] bytes)
         {

src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V63/Messages/ReceiptsMessageSerializer.cs

@@ -14,7 +14,6 @@ namespace Nethermind.Network.P2P.Subprotocols.Eth.V63.Messages
 {
     public class ReceiptsMessageSerializer : IZeroInnerMessageSerializer<ReceiptsMessage>
     {
-        private static readonly RlpLimit RlpLimit = RlpLimit.For<ReceiptsMessage>(NethermindSyncLimits.MaxReceiptFetch * 4, nameof(ReceiptsMessage.TxReceipts));
         private readonly ISpecProvider _specProvider;
         private readonly IRlpStreamDecoder<TxReceipt> _decoder;
         private readonly Func<RlpStream, TxReceipt[]> _decodeArrayFunc;
@@ -25,7 +24,7 @@ protected ReceiptsMessageSerializer(ISpecProvider specProvider, IRlpStreamDecode
         {
             _specProvider = specProvider ?? throw new ArgumentNullException(nameof(specProvider));
             _decoder = decoder ?? throw new ArgumentNullException(nameof(decoder));
-            _decodeArrayFunc = ctx => ctx.DecodeArray(nestedContext => _decoder.Decode(nestedContext), limit: RlpLimit) ?? [];
+            _decodeArrayFunc = ctx => ctx.DecodeArray(nestedContext => _decoder.Decode(nestedContext)) ?? [];
         }
 
         public void Serialize(IByteBuffer byteBuffer, ReceiptsMessage message)
@@ -91,7 +90,7 @@ public ReceiptsMessage Deserialize(IByteBuffer byteBuffer)
 
         public ReceiptsMessage Deserialize(RlpStream rlpStream)
         {
-            ArrayPoolList<TxReceipt[]> data = rlpStream.DecodeArrayPoolList(_decodeArrayFunc, limit: RlpLimit);
+            ArrayPoolList<TxReceipt[]> data = rlpStream.DecodeArrayPoolList(_decodeArrayFunc);
             ReceiptsMessage message = new(data);
 
             return message;

src/Nethermind/Nethermind.Serialization.Rlp/RlpLimit.cs

@@ -10,10 +10,8 @@ namespace Nethermind.Serialization.Rlp;
 
 public record struct RlpLimit(int Limit, string TypeName = "", ReadOnlyMemory<char> PropertyName = default)
 {
-    private const int Default = 256 * 1024 * 1024;
-
     // We shouldn't allocate any single array bigger than 1M
-    public static readonly RlpLimit DefaultLimit = new(Default);
+    public static readonly RlpLimit DefaultLimit = new();
     public static readonly RlpLimit Bloom = For<Bloom>(Core.Bloom.ByteLength);
     public static readonly RlpLimit L4 = new(4);
     public static readonly RlpLimit L8 = new(8);
@@ -22,7 +20,7 @@ public record struct RlpLimit(int Limit, string TypeName = "", ReadOnlyMemory<ch
     public static readonly RlpLimit L65 = new(65);
     private string _collectionExpression;
 
-    public RlpLimit() : this(Default) { }
+    public RlpLimit() : this((int)1.MiB()) { }
 
     public string CollectionExpression
     {