Open
Conversation
# Conflicts: # src/Nethermind/Nethermind.Xdc.Test/Helpers/XdcTestBlockchain.cs # src/Nethermind/Nethermind.Xdc/InitializeBlockchainXdc.cs # src/Nethermind/Nethermind.Xdc/TxPool/SignTransactionFilter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends XDC txpool validation beyond sign-tx-only checks, adds TRC21-aware balance/cost handling in shared txpool filters, and introduces focused XDC tests.
1- XDC custom incoming filter
The old XDC filter was effectively a sign-transaction filter. It now contains broader XDC-specific incoming validation, so it was renamed to reflect that role:
SignTransactionFilter->XdcIncomingTxFilterChecks now handled there:
2- Changes in txpool filters
Only adding checks in XDC incoming filter is not enough to match TRC21 behavior, because balance checks are enforced in common txpool filters before final acceptance.
XdcIncomingTxFilteris added last. So there could be tx which are not accepted before reaching this filter.BalanceZeroFilterandBalanceTooLowFilterwere modified by adding aITxPoolCostAndFundsProviderthat would handle:GetAdditionalFundsTryGetTransactionCostNon-TRC21 transactions fall back to the default cost path.
References on xdc side: