Skip to content

Flat/fix merge test not working with flat#10784

Draft
asdacap wants to merge 3 commits intomasterfrom
flat/fix-merge-test-not-working-with-flat
Draft

Flat/fix merge test not working with flat#10784
asdacap wants to merge 3 commits intomasterfrom
flat/fix-merge-test-not-working-with-flat

Conversation

@asdacap
Copy link
Contributor

@asdacap asdacap commented Mar 11, 2026

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

asdacap and others added 3 commits March 11, 2026 11:43
FlatDb's HasStateForBlock checks by (blockNumber, stateRoot) rather than
just the state root hash, so the pivot block must be explicitly processed
to create a snapshot. Also use CreateBlockRequestBranch for correct state
root computation across the block chain.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant