Skip to content

fix(ssz): Container decode logic for BitVector and validation fixes for container input#10797

Open
kevaundray wants to merge 2 commits intoNethermindEth:masterfrom
kevaundray:kw/sszgen-container-fix
Open

fix(ssz): Container decode logic for BitVector and validation fixes for container input#10797
kevaundray wants to merge 2 commits intoNethermindEth:masterfrom
kevaundray:kw/sszgen-container-fix

Conversation

@kevaundray
Copy link

@kevaundray kevaundray commented Mar 12, 2026

  • The generated Decode for bitvector was calling the bitlist overload method stripping the sentinel bit
  • Adds length chekcs against static size and offset ordering/bounds checks

Related to #10793

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants