Reinstate removed IGasPolicy methods and apply for eip-8037#10897
Open
damian-orzechowski wants to merge 9 commits intomasterfrom
Open
Reinstate removed IGasPolicy methods and apply for eip-8037#10897damian-orzechowski wants to merge 9 commits intomasterfrom
IGasPolicy methods and apply for eip-8037#10897damian-orzechowski wants to merge 9 commits intomasterfrom
Conversation
damian-orzechowski
requested review from
Demuirgos,
LukaszRozmej and
benaadams
as code owners
LukaszRozmej
approved these changes
Mar 20, 2026
Member
|
tests do fail |
Contributor
EVM Opcode Benchmark DiffAggregated runs: base=1, pr=1 No significant regressions or improvements detected. |
…ermindEth/nethermind into refactor/eip8037-gas-policy
Contributor
Author
Should be fixed now |
LukaszRozmej
approved these changes
Mar 20, 2026
Comment on lines
+203
to
+208
| (isSlotCreation: TIsSlotCreation.IsActive, isEip8037: TEip8037.IsActive) switch | ||
| { | ||
| (isSlotCreation: true, isEip8037: true) => ConsumeStateGas(ref gas, GasCostOf.SSetState) && UpdateGas(ref gas, GasCostOf.SSetRegular), | ||
| (isSlotCreation: true, isEip8037: false) => UpdateGas(ref gas, GasCostOf.SSet), | ||
| (isSlotCreation: false, _) => UpdateGas(ref gas, spec.GasCosts.SStoreResetCost) | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
PR #10697 removed some
IGasPolicymethods which when overriden can be used to apply muli-dimentional gas tracking (e.g. Arbitrum). Replacing them with genericUpdateGasCostmethods removes the context of the gas cost and makes it difficult to attribute correct gas type.Changes
These changes re-add removed method and apply changes for EIP-8037 inside the gas policy:
ConsumeStorageWriteConsumeNewAccountCreationTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
Required for 1.37.0 release of Arbitrum Plugin