Skip to content

fix: correct ParentHash assignment and unsafe cast in L1Block #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bilogweb3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct ParentHash assignment and unsafe cast in L1Block #9810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Nethermind/Nethermind.Optimism/CL/L1Block.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,13 @@ public sealed record L1BlockRef

public static L1BlockRef From(L1BlockInfo blockInfo)
{
// Note: L1BlockInfo doesn't contain ParentHash information
// ParentHash should be obtained separately or set to Zero for incomplete data
return new L1BlockRef
{
Hash = blockInfo.BlockHash,
Number = blockInfo.Number,
ParentHash = blockInfo.BlockHash,
ParentHash = Hash256.Zero, // Fixed: Cannot use current block hash as parent hash
Timestamp = blockInfo.Timestamp
};
}
Expand All @@ -67,7 +69,7 @@ public static L1BlockRef From(L1Block? block)
Hash = block.Value.Hash,
Number = block.Value.Number,
ParentHash = block.Value.ParentHash,
Timestamp = (ulong)block.Value.Timestamp // TODO: Potential unsafe cast
Timestamp = block.Value.Timestamp.ToUInt64(null) // Fixed: Use safe conversion method
};
}
}