Skip to content

fix(evm): use IsTracingOpLevelStorage for op-level storage events #9886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ANtutov wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix(evm): use IsTracingOpLevelStorage for op-level storage events #9886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.Storage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public static EvmExceptionType InstructionTLoad<TTracingInst>(VirtualMachine vm,
stack.PushBytes<TTracingInst>(value);

// If storage tracing is enabled, record the operation (ensuring gas remains non-negative).
if (vm.TxTracer.IsTracingStorage)
if (vm.TxTracer.IsTracingOpLevelStorage)
{
if (gasAvailable < 0) goto OutOfGas;
vm.TxTracer.LoadOperationTransientStorage(storageCell.Address, result, value);
Expand Down Expand Up @@ -106,7 +106,7 @@ public static EvmExceptionType InstructionTStore(VirtualMachine vm, ref EvmStack
vm.WorldState.SetTransientState(in storageCell, !bytes.IsZero() ? bytes.ToArray() : BytesZero32);

// If storage tracing is enabled, retrieve the current stored value and log the operation.
if (vm.TxTracer.IsTracingStorage)
if (vm.TxTracer.IsTracingOpLevelStorage)
{
if (gasAvailable < 0) goto OutOfGas;
ReadOnlySpan<byte> currentValue = vm.WorldState.GetTransientState(in storageCell);
Expand Down Expand Up @@ -400,7 +400,7 @@ internal static EvmExceptionType InstructionSStoreUnmetered<TTracingInst>(Virtua
TraceSstore(vm, newIsZero, in storageCell, bytes);
}

if (vm.TxTracer.IsTracingStorage)
if (vm.TxTracer.IsTracingOpLevelStorage)
{
vm.TxTracer.SetOperationStorage(storageCell.Address, result, bytes, currentValue);
}
Expand Down Expand Up @@ -560,7 +560,7 @@ internal static EvmExceptionType InstructionSStoreMetered<TTracingInst, TUseNetG
TraceSstore(vm, newIsZero, in storageCell, bytes);
}

if (vm.TxTracer.IsTracingStorage)
if (vm.TxTracer.IsTracingOpLevelStorage)
{
vm.TxTracer.SetOperationStorage(storageCell.Address, result, bytes, currentValue);
}
Expand Down Expand Up @@ -626,7 +626,7 @@ internal static EvmExceptionType InstructionSLoad<TTracingInst>(VirtualMachine v
stack.PushBytes<TTracingInst>(value);

// Log the storage load operation if tracing is enabled.
if (vm.TxTracer.IsTracingStorage)
if (vm.TxTracer.IsTracingOpLevelStorage)
{
vm.TxTracer.LoadOperationStorage(executingAccount, result, value);
}
Expand Down
Loading