Update Examples on RTD #1333
Closed
Update Examples on RTD #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zm711! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-13 15:23:38 UTC |
Contributor
Author
|
I'll fix pep 8 stuff at the end. |
Member
|
@zm711 The rtd logs are here: https://readthedocs.org/projects/neo/builds/ |
Contributor
Author
|
Moved this to #1429. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apdavison,
Where are the rtd logs for Neo? I'm trying to update some of the examples so I want to see why they are mostly failing on RTD (only one works currently).
I'm also not super familiar with using Group/ChannelView since I mostly use Neo from the rawio layer, but I'll try to add that into this example soon.