Fix setting python version for environment in CI#1620
Merged
alejoe91 merged 7 commits intoNeuralEnsemble:masterfrom Jan 8, 2025
Merged
Fix setting python version for environment in CI#1620alejoe91 merged 7 commits intoNeuralEnsemble:masterfrom
alejoe91 merged 7 commits intoNeuralEnsemble:masterfrom
Conversation
Contributor
Author
|
This looks like it fixed the CI issue, but we will have to wait for #1619 to make sure the CI works all the way. |
Contributor
Author
|
Not a clue where this pip issue is coming from. I'll have to do a bit more research :( It didn't appear yesterday so maybe just a ci fluke ? I'll play around a bit more. |
Contributor
Author
|
Okay @alejoe91 I finally figured it out. We were using the same cached conda env for everything. I just had to make it so we cache an environment for each python version we want to test against so the packages are all synced up. Feel free to review when you have time :) |
alejoe91
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fail until we figure out #1619 and #1618. Then this will fix #1618.
We are still having issues with python version so instead I add an explicit step to set our python version number in the environment. I'm not 100% sure this will work. I think the ideal scenario would be to actually create different cached environments for python versions instead so I might try that strategy in parallel in which case we could close this PR. Opinions?