Merged
Conversation
Contributor
|
Looks good to me. I'll merge once we get tests to pass. It looks like gin failed for the other tests, but we will see once things are working. Any chance the person can give a small test file to add to protect against issues with this version of maxwell? Let's give this a little time to see if gin comes back up. I can re-run the tests later and we will see what happens then :) |
Contributor
|
Hey @alejoe91 tests are failing. I'm a bit confused since it works in 3.12 but not 3.9. Doesn't seem like a NumPy issue since both 3.12 work. Any ideas? |
Contributor
Author
|
I had a typo :) |
zm711
approved these changes
Mar 17, 2025
Contributor
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
User indicated this fixed their issue and tests are passing merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1658