Skip to content

Rafactor processors to accept callables#250

Merged
jasonlyik merged 2 commits intodevfrom
feature/processors
Mar 11, 2025
Merged

Rafactor processors to accept callables#250
jasonlyik merged 2 commits intodevfrom
feature/processors

Conversation

@ben9809
Copy link
Copy Markdown
Contributor

@ben9809 ben9809 commented Feb 25, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.94%. Comparing base (704282d) to head (cc9b368).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #250   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files          42       42           
  Lines         772      772           
  Branches      114      114           
=======================================
  Hits          594      594           
  Misses        133      133           
  Partials       45       45           
Flag Coverage Δ
unittests 76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jasonlyik
Copy link
Copy Markdown
Contributor

jasonlyik commented Feb 25, 2025

Looks pretty good, let's update the documentation so that it is clear to users that they can use callables like lambda functions

Maybe something like:

Benchmark class:

  • preprocessors: A list of NeuroBenchPreProcessors or callable functions (e.g. lambda) with matching interfaces.
  • postprocessors: A list of NeuroBenchPostProcessors or callable functions (e.g. lambda) with matching interfaces.

What do you think?

@jasonlyik jasonlyik force-pushed the feature/processors branch from 9667fe9 to cc9b368 Compare March 11, 2025 17:30
@jasonlyik jasonlyik merged commit 6cfbdbc into dev Mar 11, 2025
6 checks passed
@V0XNIHILI V0XNIHILI deleted the feature/processors branch April 8, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants