Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #252 +/- ##
==========================================
+ Coverage 76.94% 77.83% +0.89%
==========================================
Files 42 43 +1
Lines 772 803 +31
Branches 114 118 +4
==========================================
+ Hits 594 625 +31
+ Misses 133 132 -1
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonlyik
left a comment
There was a problem hiding this comment.
Looks great, I think we should re-organize the metrics documentation setup. Right now we have pages for each of the metrics (https://neurobench.readthedocs.io/en/latest/metrics/index.html), but as there are more metrics this becomes less scalable. Potentially users may be confused whether the metrics written there are the only ones supported.
|
@ben9809 It looks like there are test-code checks pending, though I can't tell which these refer to |
Fixed |
Do you think we should include custom metrics under the metric page? |
656cb4b to
10057d5
Compare
|
Opened #254 to discuss metric documentation reorganization, this PR looks good to go |
This pull request includes several changes to enhance the functionality and maintainability of the
neurobenchpackage. The most important change include adding a new metric for activation sparsity by layer, and enhancing theNeuronHookclass to include layer names.New Metric Addition:
ActivationSparsityByLayerinneurobench/metrics/workload/activation_sparsity_by_layer.pyto calculate the sparsity of model activations on a per-layer basis.__init__.pyfile inneurobench/metrics/workloadto include the newActivationSparsityByLayermetric in the__stateless__list.Hook Enhancements:
NeuronHookclass inneurobench/hooks/neuron.pyto include an optionalnameparameter, allowing hooks to store the name of the layer they are attached to. [1] [2]is_activation_layerfunction andregister_hooksmethod inneurobench/models/neurobench_model.pyto include layer names when registering hooks. [1] [2]