-
Notifications
You must be signed in to change notification settings - Fork 4
Port all events #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port all events #23
Conversation
✅ Deploy Preview for nwborg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Overall, this looks great! |
…nt types and history
|
@rly I addressed your comments |
| <div class="d-flex flex-wrap gap-4 mb-4"> | ||
| {{ with .Date }} | ||
| <div class="d-flex gap-2 align-items-center"> | ||
| <div class="icons"> | ||
| <i class="fas fa-calendar-alt text-primary" style="font-size: 1.2rem;"></i> | ||
| </div> | ||
| <p class="inter-400 text-16 dark-600 mb-0 pt-1"> | ||
| {{ . | time.Format "January 02, 2006" }} | ||
| {{ if $.Params.endDate }} | ||
| {{ $startDate := . | time.Format "2006-01-02" }} | ||
| {{ $endDate := time.AsTime $.Params.endDate | time.Format "2006-01-02" }} | ||
| {{ if ne $startDate $endDate }} | ||
| - {{ time.AsTime $.Params.endDate | time.Format "January 2, 2006" }} | ||
| {{ end }} | ||
| {{ end }} | ||
| </p> | ||
| </div> | ||
| {{ end }} | ||
| {{ with .Params.location }} | ||
| <div class="d-flex gap-2 align-items-center"> | ||
| <div class="icons"> | ||
| <i class="fas fa-map-marker-alt text-primary" style="font-size: 1.2rem;"></i> | ||
| </div> | ||
| <p class="inter-400 text-16 dark-600 mb-0 pt-1">{{ . }}</p> | ||
| </div> | ||
| {{ end }} | ||
| {{ with .Params.eventType }} | ||
| <div class="d-flex gap-2 align-items-center"> | ||
| <div class="icons"> | ||
| <i class="fas fa-tag text-primary" style="font-size: 1.2rem;"></i> | ||
| </div> | ||
| <p class="inter-400 text-16 dark-600 mb-0 pt-1">{{ . }}</p> | ||
| </div> | ||
| {{ end }} | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the info on the right! Thanks. Now I feel like this is kind of redundant and could be removed. Up to you though.
| <div class="d-flex flex-wrap gap-4 mb-4"> | |
| {{ with .Date }} | |
| <div class="d-flex gap-2 align-items-center"> | |
| <div class="icons"> | |
| <i class="fas fa-calendar-alt text-primary" style="font-size: 1.2rem;"></i> | |
| </div> | |
| <p class="inter-400 text-16 dark-600 mb-0 pt-1"> | |
| {{ . | time.Format "January 02, 2006" }} | |
| {{ if $.Params.endDate }} | |
| {{ $startDate := . | time.Format "2006-01-02" }} | |
| {{ $endDate := time.AsTime $.Params.endDate | time.Format "2006-01-02" }} | |
| {{ if ne $startDate $endDate }} | |
| - {{ time.AsTime $.Params.endDate | time.Format "January 2, 2006" }} | |
| {{ end }} | |
| {{ end }} | |
| </p> | |
| </div> | |
| {{ end }} | |
| {{ with .Params.location }} | |
| <div class="d-flex gap-2 align-items-center"> | |
| <div class="icons"> | |
| <i class="fas fa-map-marker-alt text-primary" style="font-size: 1.2rem;"></i> | |
| </div> | |
| <p class="inter-400 text-16 dark-600 mb-0 pt-1">{{ . }}</p> | |
| </div> | |
| {{ end }} | |
| {{ with .Params.eventType }} | |
| <div class="d-flex gap-2 align-items-center"> | |
| <div class="icons"> | |
| <i class="fas fa-tag text-primary" style="font-size: 1.2rem;"></i> | |
| </div> | |
| <p class="inter-400 text-16 dark-600 mb-0 pt-1">{{ . }}</p> | |
| </div> | |
| {{ end }} | |
| </div> |
|
Thanks! I made one suggestions above - feel free to take it or leave it |
|
The event listing looks nice. However, I wasn't able to view the actual event pages. In the preview, when selecting any of the events 'View Details' I get a "404 Error: page not found!" . For events that used the nwb_hackathons repo, should we add a link to the original GitHub source since some events have additional documents in the GitHub repo? This is not critical and shouldn't hold up the PR, I'm just wondering whether that would be useful to make it easy to find the original pages for old events. |
|
@oruebel I fixed the event detail pages in the deployment preview (the base URL was wrong in the preview but you could have changed the base URL manually) |
|
Just for completeness, it would be nice to also add an entry for:
Otherwise this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all looks great to me!


No description provided.