Prevent over-wide banner #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nwborg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
Works for me with the test overlong banner.
|
|
I also increased the width of the banner on large-screen devices (> 768 px wide) from 750 px to 1000 px because it looks a bit better. |
bendichter
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt fix #26The banner text being too wide and not wrapping on Android was causing the menu item to appear offscreen. This was fixed by a concurrent PR that removed the banner, but an over-wide banner could cause this problem again in the future, so this PR now prevents an over-wide banner. It also increases the width of the banner text on large screens to 1000 px which looks a bit better in my opinion.
With help from Claude Sonnet and Cline.