Skip to content

Conversation

@bendichter
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented May 2, 2025

Deploy Preview for nwborg ready!

Name Link
🔨 Latest commit b452974
🔍 Latest deploy log https://app.netlify.com/projects/nwborg/deploys/686c74820b7fbe000965bbc5
😎 Deploy Preview https://deploy-preview-60--nwborg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static/images/community_gallery/ibl_brainmap.png has empty space at the bottom, which causes it to be cut off at the top when shown on the website. The figure should be cropped to remove the extra space to fix this issue.

@bendichter
Copy link
Contributor Author

static/images/community_gallery/ibl_brainmap.png has empty space at the bottom, which causes it to be cut off at the top when shown on the website. The figure should be cropped to remove the extra space to fix this issue.

resolved

@bendichter bendichter requested review from oruebel and stephprince May 5, 2025 14:44
@bendichter bendichter requested a review from rly May 7, 2025 20:00
@oruebel
Copy link
Contributor

oruebel commented Jul 7, 2025

The following items are missing compared to the page on nwb-overview:

@oruebel
Copy link
Contributor

oruebel commented Jul 7, 2025

The spacing between sections, and in particular at the top of the page, is quite large. It would be nice to reduce spacing a bit to make the page more compact. Maye something along the lines of https://nwb.org/tools/analysis/ . The individual items looks great, i.e., I think only the headings/section spacing could be adjusted.

Screenshot 2025-07-07 at 11 20 58 AM

@bendichter bendichter enabled auto-merge July 8, 2025 00:47
@bendichter bendichter requested a review from oruebel July 8, 2025 00:47
@oruebel oruebel disabled auto-merge July 8, 2025 01:16
oruebel
oruebel previously approved these changes Jul 8, 2025
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bendichter this is Ok to merge, but I wanted to see what your thoughts are regarding the questions I raised above concerning the 2 items that have been removed and the spacing.

- Adjusted spacing in the community gallery sections for better visual appeal.
- Updated descriptions and added new entries in the gallery section of the markdown file.
- Improved HTML structure for image handling in the community gallery layout.
@bendichter
Copy link
Contributor Author

@oruebel I addressed your comments

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@oruebel oruebel merged commit 1f06fe1 into main Jul 8, 2025
4 of 5 checks passed
@oruebel oruebel deleted the port-community-gallery branch July 8, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants