Closed
Conversation
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
from
b89dc95 to
d5fc404
Compare
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
2 times, most recently
from
2647b60 to
ae583b8
Compare
added 7 commits
February 12, 2026 19:54
Changes from 0.6.1: - Bump neuroconv to 0.7.0 - Fix Table.js: value == '' incorrectly treated 0 as empty (strict equality) - Remove UnitColumn required constraint - Sync UnitColumns with Unit schema properties (frontend linked-table validation) - Pin dandi < 0.74.0 (0.74.0 renamed dandi-staging to dandi-sandbox) - Set DANDI_STAGING_API_KEY for dandi < 0.74 compatibility
- Add ElectrodeColumns sync: ensure ElectrodeColumns includes entries for all Electrode schema properties (mirrors UnitColumns sync fix) - Remove ElectrodeColumn required fields (mirrors UnitColumn fix) - Update temporally_align_data_interfaces to accept metadata and conversion_options kwargs (neuroconv 0.7.0 API change)
Instead of pinning dandi < 0.74.0, register 'dandi-staging' as an alias for 'dandi-sandbox' in dandi's known_instances dict. This allows neuroconv 0.6.1 (which uses 'dandi-staging' internally) to work with both old and new dandi versions.
The update_recording_properties_from_table_as_json function requires data_type on each column entry. Infer it from the schema property type.
h5py 3.13+ requires HDF5 1.14.4 features (_H5T_IEEE_F16BE_g) that are not available in pytables 3.10.2's bundled HDF5 1.14.2. This causes a dlopen failure in PyInstaller builds where both libraries' HDF5 dylibs are co-bundled.
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
from
ae583b8 to
bfa8c87
Compare
neuroconv 0.7.0+ populates Device metadata with 'manufacturer' field. pynwb's Device schema includes it but sets additionalProperties: false. The frontend resolution may not properly resolve the Device definition, causing validation to reject 'manufacturer' as an additional property. Set additionalProperties: true to allow it.
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
from
89a7448 to
44d210d
Compare
…ndbox dandi >= 0.74.0 has an explicit ValueError check rejecting 'dandi-staging' after the known_instances lookup. Patching known_instances alone isn't enough. Now also patch dandi.utils.get_instance to remap 'dandi-staging' to 'dandi-sandbox' before the check runs.
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
from
6b634de to
cfe0acd
Compare
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
from
5f1a9f6 to
1c298f9
Compare
bendichter
force-pushed
the
support-neuroconv-0.7.0
branch
from
3b44fd6 to
bd55989
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
|
closing in favor of #1056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update neuroconv pin from 0.6.7 to 0.7.0 in all 4 environment files.
Changes
neuroconv[dandi,compressors] == 0.7.0in all environment YAML filesBreaking changes check (v0.7.0)
No breaking changes affect nwb-guide:
verbose=Falsedefault: nwb-guide doesn't rely on verbose behavioradd_fluorescence_traces, etc.): not used by nwb-guideget_schema_from_method_signature): not used by nwb-guidePreserved pins
dandi < 0.74.0— staging rename issue still affects this version chainneo == 0.14.1— 0.14.2 incompatible with neuroconv < 0.7.5 (0.7.0 < 0.7.5)