Skip to content

Add check subject weight #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add check subject weight #572

wants to merge 11 commits into from

Conversation

@anoushkajain
Copy link

@anoushkajain anoushkajain commented Mar 6, 2025 •
edited
Loading

Fix #370

@bendichter
Copy link
Contributor

bendichter commented Mar 6, 2025 •
edited
Loading

This is looking good! However, this PR includes two checks, which is not ideal.

I think "70kg" should pass. Here, it fails

Also, could you add a sentence in the best practices document describing this?

https://github.com/NeurodataWithoutBorders/nwbinspector/blob/dev/docs/best_practices/nwbfile_metadata.rst#subject

@stephprince stephprince added this to the 0.6.4 milestone Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.4

Development

Successfully merging this pull request may close these issues.

[Add Check]: Subject weight should have form "[numeric] [string]"

3 participants

@anoushkajain @bendichter @stephprince