-
Notifications
You must be signed in to change notification settings - Fork 24
ImageSeriesWidget fixes #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saksham20
wants to merge
56
commits into
master
Choose a base branch
from
two_photon_series_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
0606860
move tests outside the nwbwidgets package
bendichter eaa77b8
Merge remote-tracking branch 'origin/master'
bendichter 8e38592
improve plane segmentation coverage
bendichter 22396a5
Merge branch 'master' into improve_plane_seg_coverage
bendichter 3603e17
improve plane segmentation coverage
bendichter 68a4e80
Merge remote-tracking branch 'origin/improve_plane_seg_coverage' into…
bendichter 4940ee7
test show_timeseries_mpl
bendichter 3a6a197
Merge branch 'master' into improve_plane_seg_coverage
bendichter f5e21cb
Merge branch 'master' into improve_plane_seg_coverage
bendichter b438b7c
extenral files existance check fix
Saksham20 234f37d
merging with 2photonseries widget implementation to make parent class
Saksham20 e5024ad
fixes
Saksham20 6a45abd
fixes
Saksham20 45b2098
remove time window controller
Saksham20 b91e39a
inherit from ImageSeries
Saksham20 5211089
reformat
Saksham20 85f71d8
Merge branch 'improve_plane_seg_coverage' into two_photon_series_fixes
Saksham20 45b1f7c
fix 2pseries tests init arg
Saksham20 b6bcaad
bug fix
Saksham20 1095759
propagate neurodata_vis_spec
Saksham20 bf5fa4d
propagate neurodata_vis_spec
Saksham20 1136fac
Revert "fix 2pseries tests init arg"
Saksham20 2d02901
restructure
Saksham20 a7c06e7
using go.image
Saksham20 34a053c
Update nwbwidgets/ophys.py
Saksham20 8906b88
black
Saksham20 9782709
add imageseries.py
Saksham20 17d9495
using custom context manager without inheritance
Saksham20 d2b7d59
remove print st
Saksham20 22a34ff
tests setup
Saksham20 0288883
cv2 dependency
Saksham20 4d785c2
cv2 dependency
Saksham20 7dda8db
neurodataviz spec not required
Saksham20 f31e312
neurodataviz spec not required
Saksham20 f73fde3
return variable novie frames number
Saksham20 798a528
indentation
Saksham20 c8a622f
add tests for ImageSeries
Saksham20 aa04d9f
varible movie frames
Saksham20 d29ea9b
import specific fixtures
Saksham20 5509487
kwargs update for videowriter
Saksham20 b5af95c
fix video writer
Saksham20 0213ccc
movie frames loop bug fix
Saksham20 9737047
rename fixtures.py to fixtures.py
Saksham20 29b003e
Merge branch 'master' into two_photon_series_fixes
Saksham20 8e72ae9
add all callbacks as class methods
Saksham20 9bb4cf0
time slider spans frames if video file selected is other than default
Saksham20 3add69a
bug fix
Saksham20 ae8e9cc
linking foreign time slider to timeslider
Saksham20 c2e2be0
using px for faster plotting
Saksham20 fe7d182
black
Saksham20 85a0d0e
use self.get_frame
Saksham20 3ea7f58
use video start_times, visible time slider
Saksham20 329d702
get fps of video and construct external file frame index
Saksham20 6541993
fps constant across external video files
Saksham20 089ed60
movie fps fixes
Saksham20 1d131bf
external files list, indexing fixes
Saksham20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.