iOS: set modalPresentationStyle to fullscreen#101
Open
IcoDeveloper wants to merge 1 commit intoNeutrinosPlatform:masterfrom
Open
iOS: set modalPresentationStyle to fullscreen#101IcoDeveloper wants to merge 1 commit intoNeutrinosPlatform:masterfrom
IcoDeveloper wants to merge 1 commit intoNeutrinosPlatform:masterfrom
Conversation
cytostatic
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On iOS version 13 or greater it was possible to dismiss scanner overlay through swiping without getting a cancel response in callback. This causes an unresolved promise and a stuck application.
To prevent this I have reset modalPresentationStyle to fullscreen which was the default setting in iOS12.
Type of change
How Has This Been Tested?
Self-tested on real iPhone with iOS 14.5 installed.
Checklist: