Skip to content

iOS: set modalPresentationStyle to fullscreen#101

Open
IcoDeveloper wants to merge 1 commit intoNeutrinosPlatform:masterfrom
icomediasGmbh:master
Open

iOS: set modalPresentationStyle to fullscreen#101
IcoDeveloper wants to merge 1 commit intoNeutrinosPlatform:masterfrom
icomediasGmbh:master

Conversation

@IcoDeveloper
Copy link

@IcoDeveloper IcoDeveloper commented May 18, 2021

Description

On iOS version 13 or greater it was possible to dismiss scanner overlay through swiping without getting a cancel response in callback. This causes an unresolved promise and a stuck application.
To prevent this I have reset modalPresentationStyle to fullscreen which was the default setting in iOS12.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Self-tested on real iPhone with iOS 14.5 installed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants