Skip to content

Initial Windows version#62

Open
convey-gilbert wants to merge 34 commits intoNeutrinosPlatform:masterfrom
conveyGmbH:master
Open

Initial Windows version#62
convey-gilbert wants to merge 34 commits intoNeutrinosPlatform:masterfrom
conveyGmbH:master

Conversation

@convey-gilbert
Copy link

@convey-gilbert convey-gilbert commented Sep 19, 2019

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Windows 10 - only for the moment, using an OpenCVBridge lib. The Windows 8.1 version will need the integration of OpenCV via Media Transform Filter.
@convey-gilbert
Copy link
Author

convey-gilbert commented Sep 19, 2019

This is a first version supporting Windows 10. Edge detection is based on OpenCV like in the Android version of the plugin. The camera window UI and photo capture code is entirely written in JavaScript using Windows 10 only APIs and works with all Windows 10 versions using the APIs appropriate to the version. If the device supports a separate photo stream, the photo is captured from that, otherwise the video stream is used to capture the photo.
The OpenCVBridge wrapper is written C++. OpenCV 3.1. sourc code is included together with the binaries to be able to rebuild the dependent modules. The elswhere available binary OpenVC DLLs won't confirm to Microsoft Store specifications due to wrong compiler and linker flags used. So it's better to include all here in the project.
There are some additional options to provide to the scanDoc function. Description in detail is following later. Loading photos from Photo Library isn't supported yet, option will be ignored. This feature will follow later.
A Windows 8.1 branch of the plugin, using a Media Transfrom Filter instead of a Media Frame Reader is in work and will be provided with coming pull request later, maybe next week.

@ChrisTomAlx
Copy link
Collaborator

Hey @convey-gilbert
This is brilliant!! Really appreciate your contribution.

Unfortunately though I have no way of testing this, so could you maybe send me a video of your tests? I will then test and make sure this pr doesn't break any of the other platforms (Technically it shouldn't but I'd rather not risk it) and then merge it.

Cheers and have a nice day :)
Chris
Neutrinos

@convey-gilbert
Copy link
Author

convey-gilbert commented Sep 26, 2019

Hello Chris,
You can find Videos here (on x64-CPU Desktop PC with Windows 10 v. 1903 and ARM-CPU Lumia 950 with Windows 10 Mobile v. 1709):
https://secure.convey.de/publish/leadsuccess/img_0353.mov
https://secure.convey.de/publish/leadsuccess/img_0354.mov

We've also tested already with some Tablets Lenovo MIIX and Surface Pro 4 running Windows 10 v.1903 and on x64 CPU Desktop PC running Windows 8.1.

Further tests with x86 CPU (Windows 8.1 and Windows 10) and ARM CPU (Windows 8.1 RT and Windows 10 on ARM) yet missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants