Work/issue 112 Change keyboard type to according field & add toolbar to navigate textfields#125
Open
chrispySalad wants to merge 5 commits intodevelopfrom
Open
Work/issue 112 Change keyboard type to according field & add toolbar to navigate textfields#125chrispySalad wants to merge 5 commits intodevelopfrom
chrispySalad wants to merge 5 commits intodevelopfrom
Conversation
schroepf
requested changes
Apr 25, 2020
Member
schroepf
left a comment
schroepf
left a comment
There was a problem hiding this comment.
The code in this PR has already been refactored and now there are merge conflicts which need to be resolved in order to merge it...
| if textView == textFields.last { | ||
| textView.returnKeyType = .done | ||
| } | ||
| print("DEBUG: \(textView.tag)") |
Member
There was a problem hiding this comment.
- please clean out debug logs and print statements if they are not required for production
- for log statements which should remain even for production please prefer to use
log.debug,log.warning,log.errororlog.verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.