merging master into experiimental #351
+35,704
−30,746
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,10 @@ public static void ShowMetaData(Dictionary<string, object> metaData, int display | |
| CLIEngine.ShowMessage($"MetaData:", false); | ||
|
|
||
| foreach (string key in metaData.Keys) | ||
| { | ||
| if (key != "WEB5STARNFTId" && key != "{{{newnft}}}") | ||
| CLIEngine.ShowMessage(string.Concat("".PadRight(displayFieldLength), key, " = ", GetMetaValue(metaData[key])), false); | ||
| } | ||
| //CLIEngine.ShowMessage(string.Concat(" ", key, " = ", GetMetaValue(metaData[key])), false); | ||
| } | ||
| else | ||
|
|
@@ -29,7 +32,10 @@ public static string GetMetaData(Dictionary<string, object> metaData) | |
| if (metaData != null && metaData.Keys.Count > 0) | ||
| { | ||
| foreach (string key in metaData.Keys) | ||
| { | ||
| if (key != "WEB5STARNFTId" && key != "{{{newnft}}}") | ||
| metaDataString = string.Concat(metaDataString, key, " = ", GetMetaValue(metaData[key]), ","); | ||
| } | ||
|
|
||
| if (metaDataString.Length > 2) | ||
| metaDataString = metaDataString.Substring(0, metaDataString.Length - 2); | ||
|
|
@@ -51,17 +57,17 @@ public static bool IsBinary(object data) | |
| if (data is byte[]) | ||
| return true; | ||
|
|
||
| //try | ||
| //{ | ||
| // byte[] binaryData = Convert.FromBase64String(data.ToString()); | ||
|
|
||
| // for (int i = 0; i < binaryData.Length; i++) | ||
| // { | ||
| // if (binaryData[i] > 127) | ||
| // return true; | ||
| // } | ||
| //} | ||
| //catch { } | ||
|
|
||
| return false; | ||
| } | ||
|
|
@@ -134,8 +140,11 @@ public static Dictionary<string, object> ManageMetaData(Dictionary<string, objec | |
| int i = 1; | ||
| foreach (var kv in metaData) | ||
| { | ||
| if (kv.Key != "WEB5STARNFTId" && kv.Key != "{{{newnft}}}") | ||
| { | ||
| CLIEngine.ShowMessage($" {i}. {kv.Key} = {GetMetaValue(kv.Value)}"); | ||
| i++; | ||
| } | ||
|
There was a problem hiding this comment. Filtered display causes wrong metadata entries to be editedThe Additional Locations (1)
|
||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Race condition in lazy-initialized provider properties returns null
The newly uncommented provider properties (
EOSIO,Ethereum,Telos,ActivityPub) useTask.Runto asynchronously initialize the backing field but immediately return the field value without awaiting completion. On first access, this returns null because the async registration hasn't finished yet. The fire-and-forget pattern means callers receive null and subsequent accesses may still race with the ongoing initialization.Additional Locations (2)
Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L133-L153](https://github.com/NextGenSoftwareUK/OASIS/blob/c5bab2e5a1b116de1e7fc44002ce21042baa01d5/Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L133-L153)Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L217-L237](https://github.com/NextGenSoftwareUK/OASIS/blob/c5bab2e5a1b116de1e7fc44002ce21042baa01d5/Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L217-L237)