-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/440 선물 등록 시 사전 질문 작성 #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HamBP
wants to merge
26
commits into
develop
Choose a base branch
from
feat/440
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
52f8d58
chore: 버전 업
HamBP 253df9d
Merge branch 'develop' of github.com:Nexters/Boolti into develop
HamBP d6a2d6b
fix: response의 answer와 description을 nullable 타입으로 변경했어요.
HamBP 00a5a24
feat: 선물 dto 필드 추가
HamBP b965c3e
fix: 점심 모드를 변경했어요.
HamBP a42e040
refactor: 같은 브랜치에 여러 조건을 묶었어요.
HamBP ab3812d
feat: 사전 질문을 작성하는 화면을 위한 파일을 만들었어요.
HamBP 251ab9e
feat: 등록하기 시 만약 사전 질문이 있다면 질문 작성 화면으로 내비게이션 해요.
HamBP b3c78b9
feat: git에 누락된 파일을 추가했어요.
HamBP 29aca98
fix: cold start 시 로그인 정보를 가져오지 못 하는 문제를 수정했어요.
HamBP 6c4397b
feat: 공연 정보와 사전 질문 목록을 가져와요
HamBP a7c013d
feat: 공연 정보를 표시해요
HamBP 74cdac9
feat: 사전 질문 작성 폼을 만들었어요.
HamBP 85375f9
feat: 등록하기 버튼을 추가했어요.
HamBP a68e790
refactor: 텍스트들을 리소스화 했어요.
HamBP cf5897f
feat: 페이지 이탈 전 다이얼로그를 띄워줘요.
HamBP 027432f
feat: 등록하기 버튼 클릭 시 필요한 API를 호출해요.
HamBP 85f11b7
feat: 첫 번째 API 실패 시 오류 이벤트를 내보내요.
HamBP d6cd666
feat: API 호출 성공 여부를 체크하여 메시지를 띄워요
HamBP f2227a6
feat: 선물 받기 API 호출 순서를 변경했어요.
HamBP f0f1c5d
feat: 캐시된 값이 있다면 캐시된 값을 사용해요.
HamBP 93d908c
Merge branch 'develop' of github.com:Nexters/Boolti into develop
HamBP 72a9961
merge
HamBP 8acfb7c
feat: 등록 버튼 enabled 처리했어요.
HamBP bf8d778
chore: 버전 업
HamBP 7a93107
feat: retry 로직을 넣었어요.
HamBP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
.../main/java/com/nexters/boolti/presentation/screen/giftprequestion/GiftPreQuestionEvent.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.nexters.boolti.presentation.screen.giftprequestion | ||
|
|
||
| sealed interface GiftPreQuestionEvent { | ||
| data object GiftRegistered : GiftPreQuestionEvent | ||
| data object GiftRegistrationFailed : GiftPreQuestionEvent | ||
| } |
17 changes: 17 additions & 0 deletions
17
.../java/com/nexters/boolti/presentation/screen/giftprequestion/GiftPreQuestionNavigation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.nexters.boolti.presentation.screen.giftprequestion | ||
|
|
||
| import androidx.navigation.NavGraphBuilder | ||
| import androidx.navigation.compose.composable | ||
| import androidx.navigation.toRoute | ||
| import com.nexters.boolti.presentation.screen.LocalNavController | ||
| import com.nexters.boolti.presentation.screen.navigation.MainRoute | ||
|
|
||
| fun NavGraphBuilder.giftPreQuestionScreen() { | ||
| composable<MainRoute.GiftPreQuestion> { backStackEntry -> | ||
| val navController = LocalNavController.current | ||
|
|
||
| GiftPreQuestionScreen( | ||
| onBackPressed = navController::navigateUp, | ||
| ) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
receiveGift() 후 캐시 무효화 없음
선물 등록 후에도 60초간 이전 상태의 캐시를 반환합니다. receiveGift() 성공 시 giftCache.remove(giftUuid) 추가를 권장합니다