Skip to content

Conversation

@KalebCheng
Copy link

Summary

This PR introduces an option to select the key type (RSA or ECDSA) when creating SSL/TLS certificates in Nginx Proxy Manager. Previously, only ECDSA keys were generated by default, which limited flexibility for users who prefer RSA keys.

Changes

  • Updated the certificate creation UI to include a dropdown for key type selection.
  • Updated backend certificate generation logic to support RSA keys alongside ECDSA.
  • Ensured backward compatibility: existing ECDSA-only workflows remain unchanged.

Motivation

Some users prefer RSA keys for compatibility reasons or specific security requirements. This change allows users to choose between RSA and ECDSA when generating certificates.

Testing

  • Tested creating both RSA and ECDSA certificates.
  • Verified that generated certificates are valid and correctly installed in Nginx Proxy Manager.
  • Confirmed that existing ECDSA-only workflows are unaffected.

@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5121

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant