Fix SVC for RCTScrollView

Summary:
## Failure
```
 LOG  SVC RCTScrollView Invalid
 LOG  {
  "missing": {
    "validAttributes": {
      "borderBottomLeftRadius": true,
      "borderRightColor": {
        "process": "[Function processColor]"
      },
      "borderRadius": true,
      "borderLeftColor": {
        "process": "[Function processColor]"
      },
      "borderColor": {
        "process": "[Function processColor]"
      },
      "borderTopRightRadius": true,
      "borderBottomColor": {
        "process": "[Function processColor]"
      },
      "borderTopColor": {
        "process": "[Function processColor]"
      },
      "borderStyle": true,
      "borderBottomRightRadius": true,
      "borderTopLeftRadius": true,
      "removeClippedSubviews": true
    }
  },
  "unexpected": {
    "directEventTypes": {
      "topScrollToTop": {
        "registrationName": "onScrollToTop"
      }
    },
    "validAttributes": {
      "alwaysBounceHorizontal": true,
      "alwaysBounceVertical": true,
      "automaticallyAdjustContentInsets": true,
      "automaticallyAdjustKeyboardInsets": true,
      "automaticallyAdjustsScrollIndicatorInsets": true,
      "bounces": true,
      "bouncesZoom": true,
      "canCancelContentTouches": true,
      "centerContent": true,
      "contentInset": {
        "diff": "[Function pointsDiffer]"
      },
      "contentInsetAdjustmentBehavior": true,
      "directionalLockEnabled": true,
      "indicatorStyle": true,
      "inverted": true,
      "keyboardDismissMode": true,
      "maintainVisibleContentPosition": true,
      "maximumZoomScale": true,
      "minimumZoomScale": true,
      "onMomentumScrollBegin": true,
      "onMomentumScrollEnd": true,
      "onScroll": true,
      "onScrollBeginDrag": true,
      "onScrollEndDrag": true,
      "onScrollToTop": true,
      "pinchGestureEnabled": true,
      "scrollEventThrottle": true,
      "scrollIndicatorInsets": {
        "diff": "[Function pointsDiffer]"
      },
      "scrollToOverflowEnabled": true,
      "scrollsToTop": true,
      "showsHorizontalScrollIndicator": true,
      "zoomScale": true
    }
  },
  "unequal": []
}
```

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D32225225

fbshipit-source-id: 0f236256dcbcab4fe66165b5e36df2b5f785d94e

Author: RSNara

Libraries/Components/ScrollView/ScrollViewNativeComponent.js

@@ -11,75 +11,140 @@
 import type {ScrollViewNativeProps as Props} from './ScrollViewNativeComponentType';
 import type {HostComponent} from '../../Renderer/shims/ReactNativeTypes';
 import * as NativeComponentRegistry from '../../NativeComponent/NativeComponentRegistry';
+import Platform from '../../Utilities/Platform';
+
+const RCTScrollViewViewConfig =
+  Platform.OS === 'android'
+    ? {
+        uiViewClassName: 'RCTScrollView',
+        bubblingEventTypes: {},
+        directEventTypes: {
+          topMomentumScrollBegin: {
+            registrationName: 'onMomentumScrollBegin',
+          },
+          topMomentumScrollEnd: {
+            registrationName: 'onMomentumScrollEnd',
+          },
+          topScroll: {
+            registrationName: 'onScroll',
+          },
+          topScrollBeginDrag: {
+            registrationName: 'onScrollBeginDrag',
+          },
+          topScrollEndDrag: {
+            registrationName: 'onScrollEndDrag',
+          },
+        },
+        validAttributes: {
+          contentOffset: {
+            diff: require('../../Utilities/differ/pointsDiffer'),
+          },
+          decelerationRate: true,
+          disableIntervalMomentum: true,
+          pagingEnabled: true,
+          scrollEnabled: true,
+          showsVerticalScrollIndicator: true,
+          snapToAlignment: true,
+          snapToEnd: true,
+          snapToInterval: true,
+          snapToOffsets: true,
+          snapToStart: true,
+          borderBottomLeftRadius: true,
+          borderBottomRightRadius: true,
+          sendMomentumEvents: true,
+          borderRadius: true,
+          nestedScrollEnabled: true,
+          borderStyle: true,
+          borderRightColor: {process: require('../../StyleSheet/processColor')},
+          borderColor: {process: require('../../StyleSheet/processColor')},
+          borderBottomColor: {
+            process: require('../../StyleSheet/processColor'),
+          },
+          persistentScrollbar: true,
+          endFillColor: {process: require('../../StyleSheet/processColor')},
+          fadingEdgeLength: true,
+          overScrollMode: true,
+          borderTopLeftRadius: true,
+          scrollPerfTag: true,
+          borderTopColor: {process: require('../../StyleSheet/processColor')},
+          removeClippedSubviews: true,
+          borderTopRightRadius: true,
+          borderLeftColor: {process: require('../../StyleSheet/processColor')},
+        },
+      }
+    : {
+        uiViewClassName: 'RCTScrollView',
+        bubblingEventTypes: {},
+        directEventTypes: {
+          topMomentumScrollBegin: {
+            registrationName: 'onMomentumScrollBegin',
+          },
+          topMomentumScrollEnd: {
+            registrationName: 'onMomentumScrollEnd',
+          },
+          topScroll: {
+            registrationName: 'onScroll',
+          },
+          topScrollBeginDrag: {
+            registrationName: 'onScrollBeginDrag',
+          },
+          topScrollEndDrag: {
+            registrationName: 'onScrollEndDrag',
+          },
+          topScrollToTop: {
+            registrationName: 'onScrollToTop',
+          },
+        },
+        validAttributes: {
+          alwaysBounceHorizontal: true,
+          alwaysBounceVertical: true,
+          automaticallyAdjustContentInsets: true,
+          automaticallyAdjustKeyboardInsets: true,
+          automaticallyAdjustsScrollIndicatorInsets: true,
+          bounces: true,
+          bouncesZoom: true,
+          canCancelContentTouches: true,
+          centerContent: true,
+          contentInset: {
+            diff: require('../../Utilities/differ/insetsDiffer'),
+          },
+          contentOffset: {
+            diff: require('../../Utilities/differ/pointsDiffer'),
+          },
+          contentInsetAdjustmentBehavior: true,
+          decelerationRate: true,
+          directionalLockEnabled: true,
+          disableIntervalMomentum: true,
+          indicatorStyle: true,
+          inverted: true,
+          keyboardDismissMode: true,
+          maintainVisibleContentPosition: true,
+          maximumZoomScale: true,
+          minimumZoomScale: true,
+          pagingEnabled: true,
+          pinchGestureEnabled: true,
+          scrollEnabled: true,
+          scrollEventThrottle: true,
+          scrollIndicatorInsets: {
+            diff: require('../../Utilities/differ/insetsDiffer'),
+          },
+          scrollToOverflowEnabled: true,
+          scrollsToTop: true,
+          showsHorizontalScrollIndicator: true,
+          showsVerticalScrollIndicator: true,
+          snapToAlignment: true,
+          snapToEnd: true,
+          snapToInterval: true,
+          snapToOffsets: true,
+          snapToStart: true,
+          zoomScale: true,
+        },
+      };
 
 const ScrollViewNativeComponent: HostComponent<Props> =
-  NativeComponentRegistry.get<Props>('RCTScrollView', () => ({
-    uiViewClassName: 'RCTScrollView',
-    bubblingEventTypes: {},
-    directEventTypes: {
-      topScrollToTop: {
-        registrationName: 'onScrollToTop',
-      },
-    },
-    validAttributes: {
-      alwaysBounceHorizontal: true,
-      alwaysBounceVertical: true,
-      automaticallyAdjustContentInsets: true,
-      automaticallyAdjustKeyboardInsets: true,
-      automaticallyAdjustsScrollIndicatorInsets: true,
-      bounces: true,
-      bouncesZoom: true,
-      canCancelContentTouches: true,
-      centerContent: true,
-      contentInset: {
-        diff: require('../../Utilities/differ/pointsDiffer'),
-      },
-      contentOffset: {
-        diff: require('../../Utilities/differ/pointsDiffer'),
-      },
-      contentInsetAdjustmentBehavior: true,
-      decelerationRate: true,
-      directionalLockEnabled: true,
-      disableIntervalMomentum: true,
-      endFillColor: {
-        process: require('../../StyleSheet/processColor'),
-      },
-      fadingEdgeLength: true,
-      indicatorStyle: true,
-      inverted: true,
-      keyboardDismissMode: true,
-      maintainVisibleContentPosition: true,
-      maximumZoomScale: true,
-      minimumZoomScale: true,
-      nestedScrollEnabled: true,
-      onMomentumScrollBegin: true,
-      onMomentumScrollEnd: true,
-      onScroll: true,
-      onScrollBeginDrag: true,
-      onScrollEndDrag: true,
-      onScrollToTop: true,
-      overScrollMode: true,
-      pagingEnabled: true,
-      persistentScrollbar: true,
-      pinchGestureEnabled: true,
-      scrollEnabled: true,
-      scrollEventThrottle: true,
-      scrollIndicatorInsets: {
-        diff: require('../../Utilities/differ/pointsDiffer'),
-      },
-      scrollPerfTag: true,
-      scrollToOverflowEnabled: true,
-      scrollsToTop: true,
-      sendMomentumEvents: true,
-      showsHorizontalScrollIndicator: true,
-      showsVerticalScrollIndicator: true,
-      snapToAlignment: true,
-      snapToEnd: true,
-      snapToInterval: true,
-      snapToOffsets: true,
-      snapToStart: true,
-      zoomScale: true,
-    },
-  }));
+  NativeComponentRegistry.get<Props>(
+    'RCTScrollView',
+    () => RCTScrollViewViewConfig,
+  );
 
 export default ScrollViewNativeComponent;