Merged
Conversation
- Add Node.js build system with EJS templates - Create reusable partials for head, sidebar, footer, skip-link, structured data - Add article, index, pagination, and 404 page templates - Create build.js script that generates all HTML files - Add validate.js for comparing output against existing files - Add new-article.js CLI for creating new articles quickly - Convert all 8 existing articles to Markdown with YAML frontmatter - Add GitHub Actions workflow for CI (build, validate, Lighthouse) - Add netlify.toml for deployment configuration - Support for draft articles (hidden in production) - Support for YouTube embeds with proper CSP New workflow: Create .md file → npm run build → deploy Estimated time savings: 6 hours → 30 minutes
- Use full month names consistently (e.g., '4th January 2023') - Use standard ISO dates for sitemap and RSS - Simplify validation to check correctness, not byte-for-byte match - Remove unused 'diff' dependency - Consistent nickliffen.dev domain everywhere - og:title uses full title (matches <title> tag - SEO best practice)
- Use absolute paths for images (/img/ instead of ../img/) - Fix service worker to handle navigation redirects properly - Bump service worker version to 7
- Fix domain consistency: Change all nickliffen.me to nickliffen.dev - 404.ejs og:image - review-ghas-code-scanning-enterprise.md image - humans.txt site URL - Fix title consistency: 'Nick Liffen Blog' -> 'Nick Liffen's Blog' - review-ghas-code-scanning-enterprise.md title and description - Fix image extension: innersourcing.md .jpg -> .png (matches actual file) - Fix service worker (v8): - Add leading / to developer-evolution.html path - Add missing articles (why-advanced-security, leadership-principles) - Add missing pagination pages (3, 4) - Fix validate.js: Remove duplicate validate().catch() call - Fix lighthouserc.js: Change staticDistDir from './' to './dist'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD Workflow Consolidation and Enhancement:
.github/workflows/build.ymlthat handles build, type checking, testing with coverage, artifact uploads, Lighthouse CI, and automated PR comments for coverage and Lighthouse scores. This workflow replaces previous separate workflows and adds more detailed reporting and validation steps..github/workflows/ci.yml) that previously handled only Lighthouse CI, consolidating its responsibilities into the new workflow..github/workflows/codeql-analysis.yml), streamlining CI/CD processes and possibly reducing redundancy or maintenance overhead.Static Content Cleanup:
404.html).articles/building-a-simple-website.html.