Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
getTextmethod didn't handle multi-byte characters properly which would cause some bytes to get left behind. The lua string.match group%aalso only matches ASCII letters so letters like 'ä' or 'µ' would not get matched.Let's say you used the
uppercommand on the string"hëllö". You would get:HëLLHËLLÖI did not bother fixing the other more complicated methods (
title,pascal, etc.) because I don't think they're often used and it would be rather complicated as Lua doesn't have great tools for handling Unicode characters. Micro exposes thestringspackage from Go, but you'd need to rewrite the whole thing to use it.closes #15