Skip to content

Conversation

@NielBuys
Copy link
Owner

@NielBuys NielBuys commented Dec 20, 2024

Merging pull request: bcit-ci#6264

@NielBuys
Copy link
Owner Author

Fixed warnings bcit-ci#6306

@NielBuys NielBuys merged commit e7173c9 into develop Dec 20, 2024
132 checks passed
@NielBuys NielBuys deleted the tasks/PR6264 branch December 20, 2024 19:16
@jamieburchell
Copy link

@NielBuys Heads up, the tests don't appear to run on PHPUnit 10+:

$ composer run test:coverage
> @putenv XDEBUG_MODE=coverage
> phpunit --color=always --coverage-text --configuration tests/phpunit.xml
PHP Fatal error:  Cannot override final method PHPUnit\Framework\TestCase::runBare() in /home/jamie/projects/CodeIgniter/tests/mocks/ci_testcase.php on line 349

Fatal error: Cannot override final method PHPUnit\Framework\TestCase::runBare() in /home/jamie/projects/CodeIgniter/tests/mocks/ci_testcase.php on line 349
Script phpunit --color=always --coverage-text --configuration tests/phpunit.xml handling the test:coverage event returned with error code 255

@NielBuys
Copy link
Owner Author

@jamieburchell Thanks I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants