bugfix - prevent table parameter duplication in Snowflake options dictionary#190
Open
dannymeijer wants to merge 12 commits intomainfrom
Open
bugfix - prevent table parameter duplication in Snowflake options dictionary#190dannymeijer wants to merge 12 commits intomainfrom
dannymeijer wants to merge 12 commits intomainfrom
Conversation
…eter handling and prevent conflicts
…ndling and support extra params
dannymeijer
changed the title
…ropagation-wrt-table
…ropagation-wrt-table
…ropagation-wrt-table
- Resolved merge conflicts in SnowflakeBaseModel.get_options() - Preserved table parameter exclusion fix for issue #188 - Merged latest Context.from_yaml() fix from main - Updated release notes to include both bug fixes - All tests passing, table parameter conflict resolved
Member
Author
|
Ready for review |
mikita-sakalouski
requested changes
Oct 12, 2025
| user: str = Field(default=..., description="User to authenticate to the server") | ||
| password: Optional[SecretStr] = Field(default=None, description="Password belonging to the username") | ||
| private_key: Optional[SecretStr] = Field(default=None, alias="pem_private_key", description="Private key for authentication") | ||
| private_key: Optional[SecretStr] = Field( |
Contributor
There was a problem hiding this comment.
I don't think we should add private_key as input param for JDBC, as it is not option in Spark JDBC
…ropagation-wrt-table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue in
SnowflakeBaseModel.get_options()where the 'table' parameter was being included in the options dictionary, causing conflicts in nested operations - likeAddColumn- during schema synchronization. The fix excludes the table parameter while maintaining proper parameter handling for Snowflake connections, ensuring that operations can properly cascade options without parameter conflicts.The implementation also improves overall parameter handling across the Snowflake and JDBC reader classes while maintaining backwards compatibility.
Related Issue
closes #188
How Has This Been Tested?
New test has been added to cover for this scenario
Types of changes
Checklist: