-
Notifications
You must be signed in to change notification settings - Fork 0
feat: replace landing page with static HTML #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nikhi-l
wants to merge
2
commits into
main
Choose a base branch
from
codex/replace-current-landing-page-with-landingpage.html
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,5 @@ | ||
| import Link from 'next/link'; | ||
| import Spline from '@splinetool/react-spline/next'; | ||
| import { Button } from '@/components/ui/button'; | ||
| import { redirect } from 'next/navigation'; | ||
|
|
||
| export default function Home() { | ||
| return ( | ||
| <main className="relative h-screen w-screen"> | ||
| <Spline scene="https://prod.spline.design/DS0UgrDOifhNt9T6/scene.splinecode" /> | ||
| <div className="absolute bottom-8 left-1/2 -translate-x-1/2"> | ||
| <Button | ||
| asChild | ||
| className="bg-[hsl(246,82%,60%)] text-white hover:opacity-90" | ||
| > | ||
| <Link href="/login">cerch now</Link> | ||
| </Button> | ||
| </div> | ||
| </main> | ||
| ); | ||
| redirect('/landingpage.html'); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Landing Page Replacement PRD | ||
|
|
||
| ## Context | ||
| The existing landing page is a minimal Spline demo. A richer landing page exists in `landingpage.html` with animations and marketing copy. We want this new page to serve as the site's entry point. | ||
|
|
||
| ## Goals | ||
| - Serve `landingpage.html` when users visit `/`. | ||
| - Ensure primary call‑to‑action buttons navigate to the chat window. | ||
|
|
||
| ## Non-goals | ||
| - Redesign of chat or authentication flows. | ||
| - Copy or design changes beyond integrating the provided HTML. | ||
|
|
||
| ## Scope & Assumptions | ||
| - Replace `/` route with static HTML file in `public`. | ||
| - Update CTA buttons (`Generate my first list`) to link to `/chat`. | ||
| - Assume existing chat route at `/chat` remains unchanged. | ||
|
|
||
| ## Approach | ||
| - Move `landing.html` to `public/landingpage.html`. | ||
| - Replace `app/page.tsx` with a redirect to `/landingpage.html`. | ||
| - Convert CTA buttons to anchor tags targeting `/chat`. | ||
|
|
||
| ## Impacted Areas | ||
| - `app/page.tsx`. | ||
| - `public/landingpage.html`. | ||
|
|
||
| ## Risks & Mitigations | ||
| - **Risk:** Static HTML may bypass Next.js layout styling. | ||
| - *Mitigation:* Keep page self‑contained with its own styles. | ||
| - **Risk:** Redirect loop if file missing. | ||
| - *Mitigation:* Ensure `landingpage.html` committed under `public/`. | ||
|
|
||
| ## Validation | ||
| - Run linting and Playwright tests (`pnpm lint`, `pnpm test`). | ||
| - Manually verify landing page loads and CTA links to `/chat`. | ||
|
|
||
| ## Rollout/Rollback | ||
| - Rollout: deploy updated build. | ||
| - Rollback: revert commit to restore previous landing page. | ||
|
|
||
| ## Links | ||
| - PR: (TBD) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Redirect makes root page server-only and breaks client imports
Replacing the home component with
redirect('/landingpage.html')turnsapp/page.tsxinto a server‑only module. Any existing client components or tests that import this page now fail to compile withThis module cannot be imported from a Client Component module(as seen inpnpm test). Consider performing the redirect inmiddleware.ts, a Next.js rewrite, or a client‑side hook so the page remains importable where the client build expects it.Useful? React with 👍 / 👎.