Add onDrawerChanged event handler#36
Open
Fironn wants to merge 2 commits intoNikhilVadoliya:masterfrom
Open
Conversation
|
Can this get merged? |
|
I reimplemented this on my own branch. |
Owner
|
NikhilVadoliya
requested changes
Mar 17, 2025
lib/src/slider.dart
Outdated
| vsync: this, duration: Duration(milliseconds: widget.animationDuration)) | ||
| ..addStatusListener((status) { | ||
| if (status == AnimationStatus.completed) { | ||
| widget.onDrawerChanged!(true); |
Owner
There was a problem hiding this comment.
It will throw the error if the user does not use onDrawerChanged.
use => onDrawerChanged?.call();
lib/src/slider.dart
Outdated
| if (status == AnimationStatus.completed) { | ||
| widget.onDrawerChanged!(true); | ||
| } else if (status == AnimationStatus.dismissed) { | ||
| widget.onDrawerChanged!(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: Adding the
onDrawerChangedevent handler for monitoring changes in the Drawer status.Motivation: Hello, and thank you for creating this wonderful library. I am interested in using it and would like to capture events when the Drawer status changes. Therefore, I have already tested it and can confirm it works on iOS 18.0.
Usage: By including the argument
you can monitor the Drawer open/close events.