Improve drag handling and animation#38
Open
rustobi wants to merge 3 commits intoNikhilVadoliya:masterfrom
Open
Improve drag handling and animation#38rustobi wants to merge 3 commits intoNikhilVadoliya:masterfrom
rustobi wants to merge 3 commits intoNikhilVadoliya:masterfrom
Conversation
rustobi
changed the title
Author
|
Feel free to test the example app on both the master branch and this MR branch. I was thinking about disabling the animation curve during manual dragging, but this caused issues when the drawer closes or opens automatically. It would feel at least natural for the drag interaction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR ensures that dragging is only processed when _isDragging is set to true.
Previously, the slider could incorrectly open when the user interacted at the opposite end of the screen.
Additionally, a start offset is now applied to the drag delta to smooth the animation and prevent abrupt jumps when beginning to drag.