BreakPoint -> Starter Dev #53
Conversation
…ebugging id issue on create leave request
… for request, todo: addapt send mail to admin and manager
… and mail, confirmation page finish:FINISH BUTTONS
…isplay for requests
…user with requestto same ID, add conditional in main dashbaord
…profile permissions
Breakpoint to dev
There was a problem hiding this comment.
add this file to gitignore
| MAIL_PASSWORD=PASSWORD | ||
| MAIL_ENCRYPTION=tls | ||
| MAIL_FROM_ADDRESS=[email protected] | ||
| MAIL_FROM_NAME="Leave Management System" |
There was a problem hiding this comment.
${APP_NAME} is more appropriate for this and not sure for the rest of the values
| bool $is_disabled = false, | ||
| array $permissions_array = [] | ||
| array $permissions_array = [], | ||
| int $paid_leaves_max, |
There was a problem hiding this comment.
these attributes sound like are too specific to be included in the general user entity
| const auth = useAuth(); | ||
| const [block, element] = useBEMBuilder( | ||
| "admin-layout", |
There was a problem hiding this comment.
this should be leaved, will remove minimizing ablity
| alt="Logo" | ||
| src="@/../assets/images/sm_logo_white.png" | ||
| /> | ||
| BreakPoint |
There was a problem hiding this comment.
This looks like business logic specific
There was a problem hiding this comment.
looks like unnecessary around Datatable, unless should be extended in the future
| requestToUser: UserFormItem; | ||
| } | ||
|
|
||
| export interface LeaveRequestsTableResponse { |
There was a problem hiding this comment.
there should be generic type "PaginatedAPIResponse" or something to use here
| @@ -0,0 +1,12 @@ | |||
| import type { USER_PERMISSIONS, USER_ROLES } from "@/modules/users/constants"; | |||
|
|
|||
| export type Permission = | |||
There was a problem hiding this comment.
use the types from users module, no need to redefine
| </div> | ||
| </template> | ||
| <style scoped> | ||
| .color-picker { |
| background: transparent; | ||
| cursor: pointer; | ||
| width: 40px; | ||
| height: 40px; |
There was a problem hiding this comment.
use css variables... prefer the ones defined in the core
| manualLoading.value = false; | ||
| }, | ||
| onError: (error) => { | ||
| // @ts-ignore |
| }, | ||
| onError: (error) => { | ||
| // @ts-ignore | ||
| const firstErrorMessage = error.errors ? Object.values(error.errors)[0][0] : "An unexpected error occurred"; |
There was a problem hiding this comment.
maybe improve the format of the errors returned
|
Better separate Frontend - Backend - Infrastructure changes in separate PR's |
3 participants
Malce buchkurush jet ama ke se sredva poleka. Ne e finalno ova, samo kolku da raboti
Ke se prat relaci and shitoj uste, da ne povikvame balamurski apinja na sekoe.
Ama ubo e da se najdu kako Crud sho raboti.
Ete i so e aplikacijata
https://docs.google.com/document/d/1R-UHeO78mMEglwkzPCPQrsAQfhTELIxlbPXk06k7MZs/edit?usp=sharing