Enable lookup [SyncWith:zkllvm#340] #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokoshn
force-pushed
the
340-lookup-support-multiprover
branch
5 times, most recently
from
05b865f to
f12554d
Compare
Iluvmagick
suggested changes
Nov 24, 2023
Iluvmagick
left a comment
Iluvmagick
left a comment
There was a problem hiding this comment.
Still need to run the tests with proofs.
akokoshn
force-pushed
the
340-lookup-support-multiprover
branch
21 times, most recently
from
44e5283 to
48a3061
Compare
nkaskov
force-pushed
the
340-lookup-support-multiprover
branch
from
48a3061 to
07cd01b
Compare
x-mass
changed the title
nkaskov
force-pushed
the
340-lookup-support-multiprover
branch
from
07cd01b to
9ea5f45
Compare
|
Tests will be run in sync with other PRs containing |
nkaskov
force-pushed
the
340-lookup-support-multiprover
branch
2 times, most recently
from
c99fc12 to
bf63304
Compare
akokoshn
force-pushed
the
340-lookup-support-multiprover
branch
2 times, most recently
from
8a8ada9 to
067c3a7
Compare
akokoshn
force-pushed
the
340-lookup-support-multiprover
branch
from
067c3a7 to
e983c10
Compare
Author
|
@Iluvmagick , manually checked proving sha256 in multi provers mode (1th prover has no lookup, 2th - sha256 with lookup) |
nkaskov
approved these changes
Dec 4, 2023
Iluvmagick
approved these changes
Dec 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #287. Closes #340.