Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Use bitfield for chopping non-native values #210

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use bitfield for chopping non-native values #210

wants to merge 5 commits into from

Conversation

@x-mass
Copy link
Contributor

@x-mass x-mass commented Sep 18, 2023 •
edited
Loading

Replaced hardcoded bit shifting logic for converting non_native type to array of native ones with marshalling multiprecision bitfield. Added tests for this

@x-mass x-mass requested a review from nkaskov September 18, 2023 11:20
@x-mass x-mass self-assigned this Sep 18, 2023
@x-mass x-mass marked this pull request as draft September 18, 2023 13:15
@x-mass x-mass changed the title Use core pack(...) for chopping non-native values Use algebra split_field_element() for chopping non-native values Sep 20, 2023
@x-mass x-mass mentioned this pull request Sep 20, 2023
Closed
@x-mass x-mass changed the title Use algebra split_field_element() for chopping non-native values Use bitfield for chopping non-native values Oct 9, 2023
@nkaskov nkaskov marked this pull request as ready for review November 10, 2023 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nkaskov nkaskov Awaiting requested review from nkaskov

At least 1 approving review is required to merge this pull request.

Assignees

@x-mass x-mass

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@x-mass