Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Testing rig now uses all empty constant columns for lookup tables. #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Testing rig now uses all empty constant columns for lookup tables. #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/test_plonk_component.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,13 @@ namespace nil {
}

if constexpr (nil::blueprint::use_lookups<component_type>()) {
// Components with lookups may use constant columns.
// But now all constants are placed in the first column.
// So we reserve the first column for non-lookup constants.
// Rather universal for testing
// We may start from zero if component doesn't use ordinary constants.
// Use all of the unused constant columns for lookups
std::vector<size_t> lookup_columns_indices;
for( std::size_t i = 1; i < assignment.constants_amount(); i++ ) lookup_columns_indices.push_back(i);
for(std::size_t i = 0; i < desc.constant_columns; i++) {
if(assignment.constants()[i].size() == 0) {
lookup_columns_indices.push_back(i);
}
}

std::size_t cur_selector_id = 0;
for(const auto &gate: bp.gates()){
Expand Down