Merged
Conversation
The previous check only compared issuer and subject on `payloads[1]`, which broke when the subject was an issuer at a different position in the delegation chain. Now checks all payloads for a match.
The check is already guaranteed by the combination of DIFFERENT_SUBJECTS, ROOT_KEY_SIGNATURE_MISSING, and ISSUER_AUDIENCE_MISMATCH + signature verification. Removing it simplifies the validation rules and unblocks delegated auth chains where the subject never appears as an issuer.
Update pnpm 10.28.0 → 10.30.1 and all dependencies.
tim-hm
force-pushed
the
feat/move-to-credits
branch
from
e2c581f to
522f991
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.