Match CRLF when condensing template new lines #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private condenseNewLines(snippet: string): string { | ||
| return snippet.replace(/\n{3,}/gm, "\n\n"); | ||
| return snippet.replace(/(?:\r?\n){3,}/gm, "\n\n"); |
There was a problem hiding this comment.
I think the case of \r\n{3,} should be replaced with\r\n\r\n not \n\n
|
Hi sorry for the delay in checking this. Can you rebase master and add a test case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #198, where templates saved with CRLF line returns will generate unwanted trailing white spaces and new lines.