Skip to content

Adding impurity in document.tsx code #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding impurity in document.tsx code #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f6725e
Adding impurity in document.tsx code
NirajC-Microsoft May 16, 2025
8f420cd
change suggested from copilot
NirajC-Microsoft May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/frontend/src/pages/document/Document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const Document = (): JSX.Element => {
setIsLoading(true); // Step 2
try {
const response = await documentRead(id);
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before calling response.json(), check response.ok and handle non-2xx statuses explicitly to avoid parsing errors on a failed request.

Suggested change
const response = await documentRead(id);
const response = await documentRead(id);
if (!response.ok) {
throw new Error(`Failed to fetch document: ${response.status} ${response.statusText}`);
}

Copilot uses AI. Check for mistakes.

const data = await response.json();
setDocument(data);
const data: DocumentData = await response.json(); // Parse response as JSON
setDocument(data); // Use the parsed and typed data
} catch (error) {
console.error(error);
setDocument(null);
Expand All @@ -30,7 +30,7 @@ const Document = (): JSX.Element => {
};

if (params.id) {
getDocument(params.id);
getDocument(params.id as string); //
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of casting params.id with as string, you can type your route params when calling useParams<{ id: string }>() to avoid manual casting.

Suggested change
getDocument(params.id as string); //
getDocument(params.id); //

Copilot uses AI. Check for mistakes.

}
}, [params.id]);

Expand All @@ -41,7 +41,7 @@ const Document = (): JSX.Element => {
) : document ? (
<p>{document.content}</p>
) : (
<h1>Document not found. Please try again.</h1>
<p>Document not found. Please try again.</p>
)}
</>
);
Expand Down
Loading