Open
Conversation
Co-authored-by: sosthene-nitrokey <109070476+sosthene-nitrokey@users.noreply.github.com>
…into feat/pqc-v2
…into feat/pqc-v2
Collaborator
sosthene-nitrokey
left a comment
sosthene-nitrokey
left a comment
There was a problem hiding this comment.
This looks good.
Have you tested in on a device?
| @@ -1,4 +1,4 @@ | |||
| [toolchain] | |||
| channel = "1.82.0" | |||
| channel = "1.85.0" | |||
Collaborator
There was a problem hiding this comment.
Can you please explain why this is necessary? We can bump it but it requires also bumping the release in the CI, which needs to be done in in the Dockerfile and built/uploaded manually by one of us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-create of #598 after renaming source branch.
This PR adds use of the trussed-pqc-backend crate to support Dilithium for signatures.
Depends on: