Removes spaces and minus signs when saving the OTP entry #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
approved these changes
Nov 11, 2025
daringer
requested changes
Nov 11, 2025
Collaborator
daringer
left a comment
daringer
left a comment
There was a problem hiding this comment.
this is only the "checker" functionality, which decides if the button is clickable - can you please also do this change before actually saving the otp-secret. This is here: https://github.com/Nitrokey/nitrokey-app2/blob/main/nitrokeyapp/secrets_tab/__init__.py#L855
Collaborator
|
oh and please rebase (for the ci to go through) and use verified commits - thanks |
Contributor
Author
|
You mean line 842 where the secret is processed? |
gsnw-sebast
force-pushed
the
fix-totp
branch
from
db7a271 to
0b7a4d6
Compare
Contributor
Author
|
I tested my change and it works with TOTP |
daringer
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sites, such as PayPal and others, output the OTP string with spaces after every 4th character.
Entering this string results in the error message
Secret is not in Base32.However, removing the spaces makes it work. To be on the safe side, the pull request also removes the minus sign, too.
The pull request is untested because I don't have a suitable environment for testing and I haven't checked whether the other OTP variants contain spaces.