Simplify ruff configuration #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import sorting check, previously done with isort, is now part of the normal ruff check so we don’t need a separate target for it.
Member
Author
|
I would also consider disabling the magic trailing comma. From my experience, it is mostly added accidentally and not intentionally. But as this changes the formatting of some files, I did not include it yet. |
Collaborator
|
for me it would be ok to include the magic-comma removal here, or should we go for another PR with this ? |
Member
Author
|
Sure, if you agree I’ll include it. |
daringer
approved these changes
Nov 18, 2025
robin-nitrokey
temporarily deployed
to
testpypi
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redundant ruff configuration, makes the ruff binary configurable and removes the separate import check.