Skip to content

Conversation

@alexgithublab
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

The successful documentation build was deployed for preview:

@alexgithublab
Copy link
Collaborator Author

it was buggy sorry but I created two other branch that can be deleted

@jans23
Copy link
Member

jans23 commented Oct 9, 2025

@sosthene-nitrokey please review not just the changes but the entire (unchanged) file.

@jans23
Copy link
Member

jans23 commented Oct 9, 2025

@alexgithublab BTW, could you fix the syntax errors which were introduced earlier?

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@alexgithublab
Copy link
Collaborator Author

sorry for all these commits but I don't have any error locally so it was the only way for me to test, I'll try to rebase

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@alexgithublab
Copy link
Collaborator Author

also note that "shell-session" code block are not readable with white theme why not using bash instead ?

@jans23
Copy link
Member

jans23 commented Oct 10, 2025

@sosthene-nitrokey AFAIK this is outdated, isn't it?

You can store up to 50 entries, one entry can contain login, password, comment and OTP.

@sosthene-nitrokey
Copy link
Contributor

sosthene-nitrokey commented Oct 10, 2025

No it hasn't changed: https://github.com/Nitrokey/nitrokey-3-firmware/blob/86b391de5da11d9bc2982faa7594100ae91685a0/components/apps/src/lib.rs#L7

The limitation here is the iteration time over the entries which grows in $O(n^3)$, while for FIDO credentials it's the storage (secrets app uses the external flash).

@alexgithublab
Copy link
Collaborator Author

Then I think the fact sheet is wrong and the doc in the nkapp2

@jans23
Copy link
Member

jans23 commented Oct 10, 2025

I will fix the number in the factsheet. @alexgithublab please fix the doc in the nkapp2.

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@daringer daringer merged commit 7b745a5 into main Oct 13, 2025
3 checks passed
@daringer daringer deleted the alexgithublab-patch-1 branch October 13, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants