nk3.updates: Remove reboot during update and release v0.3.1#71
Merged
robin-nitrokey merged 2 commits intomainfrom Mar 28, 2025
Merged
nk3.updates: Remove reboot during update and release v0.3.1#71robin-nitrokey merged 2 commits intomainfrom
robin-nitrokey merged 2 commits intomainfrom
Conversation
In v0.3.0, we added a reboot during the update to ensure that the device status is up to date. This was by mistake – we decided to skip this change for better compatibility with QubesOS. The current implementation was broken anyway as the device handle used for the reboot to bootloader was invalidated by the first reboot.
This removes an unintended reboot during the Nitrokey 3 update.
sosthene-nitrokey
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v0.3.0, we added a reboot during the update to ensure that the device status is up to date. This was by mistake – we have decided to skip this change for better compatibility with QubesOS but I forgot that. The current implementation was broken anyway as the device handle used for the reboot to bootloader was invalidated by the first reboot.