Draft
Conversation
This allows dropping the dependency on utf8-string (of the library) completely since we don't need to be faithful when converting the input to a String for the sake of the error message (and can just liberally use the Unicode Replacement Character instead). simpleParsecBS was added in Cabal 3.4, so we can no longer build against the GHC 8.10.7 core package version, but we no longer need that anyway.
We still want to access nonpreferred versions in our parsed DB on occasion. E.g. cabal2nix cabal://chronologique currently fails because the package is deprecated and thus no version is preferred.
Now that we no longer filter out nonpreferred versions, users may want to do this themselves. We expose (for completeness sake and because we need to compute it anyways) the preferred VersionRange and tag every version individually for convenience.
Before the recent changes to hackage-db, cabal2nix cabal://<pkgname> (i.e. no explicit version requested) would never pick a nonpreferred version. This change restores the old behavior for packages that have preferred versions available. If none is available, we keep picking the latest one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.