Conversation
In NixOS#1549 diffs were offloaded to github for performance reasons. While in some endpoints github accepts `.git` suffixed in the repository name, in the comparison endpoint this does not seem to be the case. Specifically, on the main nixos org hydra this isn't working: Example job: https://hydra.nixos.org/build/320178054 Generates a comparison link like so: https://github.com/NixOS/nixpkgs.git/compare/078d69f03934859a181e81ba987c2bb033eebfc5...1cd347bf3355fce6c64ab37d3967b4a2cb4b878c This just stips away the suffix and seems to work fine in local testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1549 diffs were offloaded to github for performance reasons.
While in some endpoints github accepts
.gitsuffixed in the repository name, in the comparison endpoint this does not seem to be the case.Specifically, on the main nixos org hydra this isn't working:
Example job: https://hydra.nixos.org/build/320178054
Generates a comparison link like so:
https://github.com/NixOS/nixpkgs.git/compare/078d69f03934859a181e81ba987c2bb033eebfc5...1cd347bf3355fce6c64ab37d3967b4a2cb4b878c
This just stips away the suffix and seems to work fine in local testing.
cc @dasJ