Merged
Conversation
This reduces the number of queries in a list view from >250 to ~30. Total query time goes down from ~60ms to ~20ms (tested locally). Reason for the slowdown was that the template filter would query the database on every conditionally displayed button. The remaining overhead is from inefficient querying of the activity log. But this need to be thought through properly. We may not need the edit types and could possibly rely on `pghistory` exclusively. It's really ugly how this fix is implemented, sorry. I just wanted to get it out of the way. We need to redesign how data is mashed up for the templates.
This is a hotfix because upstream decided to mass-edit old records to add microsecond precision (!) to publication dates. While that probably has some good reason, for us it triggers matches with very old CVEs, degrading user experience. Up to now it would also create duplicate containers, which should be cleaned up in the future. The general issue still needs to be addressed properly by updating existing records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.