Skip to content

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented May 24, 2025

No description provided.

@Mic92 Mic92 requested a review from a team as a code owner May 24, 2025 10:21
@Mic92 Mic92 enabled auto-merge (rebase) May 27, 2025 14:20
@Mic92 Mic92 merged commit db838be into NixOS:master May 27, 2025
4 checks passed
@Mic92 Mic92 deleted the bump-nixpkgs branch May 27, 2025 14:27
@fricklerhandwerk
Copy link
Collaborator

Hey thanks @Mic92, looks good generally. I'm just a bit confused why we now have two npins default.nix --
IIRC the single file was deliberately modified to take an argument so we can use it from different call sites. Did you do that to allow easier version upgrades?

@Mic92
Copy link
Member Author

Mic92 commented May 27, 2025

Wasn't aware of this modification. I did notice the API change but thought this was because of the version bump. Creating a symlink might also solve deduplicate the files. However not modifying those files also doesn't seem to be too bad.

@fricklerhandwerk
Copy link
Collaborator

Symlink it is then. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants