Add hydra proxy header with well-known X-From #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just so we’re clear, I haven’t tested this. Unfortunately it doesn’t look like we get a preview deploy from opening this PR. |
jfly
approved these changes
May 31, 2025
Member
Author
|
Looks like we lost two redirect rules. Looking at nixos-homepage I think the netlify.toml needs to be part of the build output. |
Member
Author
|
Reverting from the PR UI fails with
|
mweinelt
added a commit
to mweinelt/nix.dev
that referenced
this pull request
May 31, 2025
This reverts commit 7977520. This did not work, presumably because the netlify.toml is in the wrong directory. Needs further investigation.
mweinelt
added a commit
that referenced
this pull request
May 31, 2025
mweinelt
added a commit
to mweinelt/nix.dev
that referenced
this pull request
May 31, 2025
…ixOS#1149) This reverts commit 0441a00. But this time we install the netlify.toml into the root of the page.
mweinelt
added a commit
that referenced
this pull request
May 31, 2025
mweinelt
added a commit
to mweinelt/nix.dev
that referenced
this pull request
May 31, 2025
…#1147)" (NixOS#1149) (NixOS#1150)" This reverts commit 7cd91bd.
mweinelt
added a commit
to mweinelt/nix.dev
that referenced
this pull request
May 31, 2025
…#1147)" (NixOS#1149) (NixOS#1150)" This reverts commit 7cd91bd. Nope, this doesn't work either. Let's wait for someone with a clue.
mweinelt
added a commit
that referenced
this pull request
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has now become required to bypass anubis on hydra.nixos.org.
Thanks, @adamcstephens, for preparing this.