Skip to content

Conversation

@siraben
Copy link
Member

@siraben siraben commented Sep 10, 2025

No description provided.

@siraben siraben requested review from a team, alejandrosame and infinisil as code owners September 10, 2025 08:36
@siraben siraben force-pushed the typo-fix branch 2 times, most recently from d71e316 to 770120c Compare September 11, 2025 06:18
@djacu
Copy link
Member

djacu commented Sep 12, 2025

I read through all the changes. Other than the comments I left, everything looks solid. Thanks for all the improvements @siraben!

@siraben siraben force-pushed the typo-fix branch 3 times, most recently from 8c8ee4e to 35a4fc7 Compare September 12, 2025 06:31
@siraben
Copy link
Member Author

siraben commented Sep 15, 2025

@djacu addressed all your comments.

@siraben siraben closed this Sep 22, 2025
@siraben siraben reopened this Sep 22, 2025
@siraben
Copy link
Member Author

siraben commented Sep 22, 2025

@djacu can we get this merged?

@djacu
Copy link
Member

djacu commented Sep 22, 2025

@siraben I'm sorry but I do not have merge authority in this repository. @alejandrosame or @hsjobeki would you have time to take a look. I did a thorough review of the changes and they look good if that helps.

Copy link

@hsjobeki hsjobeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes ❤️

@hsjobeki hsjobeki merged commit b366f81 into NixOS:master Sep 23, 2025
8 checks passed
@siraben siraben deleted the typo-fix branch September 30, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants